PM / devfreq: Fix kernel oops on governor module load
authorEzequiel Garcia <ezequiel@collabora.com>
Fri, 21 Jun 2019 21:39:49 +0000 (18:39 -0300)
committerMyungJoo Ham <myungjoo.ham@samsung.com>
Sat, 24 Aug 2019 11:11:12 +0000 (20:11 +0900)
commit7544fd7f384591038646d3cd9efb311ab4509e24
tree77e3ad9912bd3e312b8322fb405505ecd8f8af73
parent0a453aca94bd7886bca86cc78ce2771f55152232
PM / devfreq: Fix kernel oops on governor module load

A bit unexpectedly (but still documented), request_module may
return a positive value, in case of a modprobe error.
This is currently causing issues in the devfreq framework.

When a request_module exits with a positive value, we currently
return that via ERR_PTR. However, because the value is positive,
it's not a ERR_VALUE proper, and is therefore treated as a
valid struct devfreq_governor pointer, leading to a kernel oops.

Fix this by returning -EINVAL if request_module returns a positive
value.

Fixes: b53b0128052ff ("PM / devfreq: Fix static checker warning in try_then_request_governor")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
drivers/devfreq/devfreq.c