thermal: qcom: Fix comparison with uninitialized variable channels_available
authorColin Ian King <colin.king@canonical.com>
Tue, 16 Feb 2021 15:16:26 +0000 (15:16 +0000)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 16 Feb 2021 18:05:23 +0000 (19:05 +0100)
commit74369d041a0a3e9e57de50efd4bd4bc10564e254
tree7d11ff927673685544b2d1a9bfcc21f2b04cb55a
parentca66dca5eda6bd16b7b27fed2a034f2396df5627
thermal: qcom: Fix comparison with uninitialized variable channels_available

Currently the check of chip->channels[i].channel is against an the
uninitialized variable channels_available.  I believe the variable
channels_available needs to be fetched first by the call to adc_tm5_read
before the channels check. Fix the issue swapping the order of the
channels check loop with the call to adc_tm5_read.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210216151626.162996-1-colin.king@canonical.com
drivers/thermal/qcom/qcom-spmi-adc-tm5.c