befs: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 9 May 2023 01:41:36 +0000 (01:41 +0000)
committerKees Cook <keescook@chromium.org>
Tue, 30 May 2023 23:42:00 +0000 (16:42 -0700)
commit7391928025f28cd4cab43e59d2b4e36509b9337e
tree8cb9d32863953511505ce6624961ceed7ad31a94
parent2f088dfc1878108748018af0d2e3748ba9eee1e9
befs: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated.
In an effort to remove strlcpy() completely, replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230509014136.2095900-1-azeemshaikh38@gmail.com
fs/befs/btree.c
fs/befs/linuxvfs.c