eventfs: Do not invalidate dentry in create_file/dir_dentry()
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 20 Nov 2023 23:51:07 +0000 (18:51 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 21 Nov 2023 00:02:11 +0000 (19:02 -0500)
commit71cade82f2b553a74d046c015c986f2df165696f
tree71c0cd89e42439aa74b18a0d9ea4b954fc8b3f4f
parent88903daecacf03b1e5636e1b5f18bda5b07030fc
eventfs: Do not invalidate dentry in create_file/dir_dentry()

With the call to simple_recursive_removal() on the entire eventfs sub
system when the directory is removed, it performs the d_invalidate on all
the dentries when it is removed. There's no need to do clean ups when a
dentry is being created while the directory is being deleted.

As dentries are cleaned up by the simpler_recursive_removal(), trying to
do d_invalidate() in these functions will cause the dentry to be
invalidated twice, and crash the kernel.

Link: https://lore.kernel.org/all/20231116123016.140576-1-naresh.kamboju@linaro.org/
Link: https://lkml.kernel.org/r/20231120235154.422970988@goodmis.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Fixes: 407c6726ca71 ("eventfs: Use simple_recursive_removal() to clean up dentries")
Reported-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
fs/tracefs/event_inode.c