perf/arm-cmn: Fix DTC reset
authorRobin Murphy <robin.murphy@arm.com>
Wed, 24 May 2023 16:44:32 +0000 (17:44 +0100)
committerWill Deacon <will@kernel.org>
Mon, 5 Jun 2023 14:35:52 +0000 (15:35 +0100)
commit71746c995cac92fcf6a65661b51211cf2009d7f0
tree759ee5221f2b4c40619efdaec48b843cc7910db6
parent7bd42f122c7cf1e8101519dced3e07866b81e0d2
perf/arm-cmn: Fix DTC reset

It turns out that my naive DTC reset logic fails to work as intended,
since, after checking with the hardware designers, the PMU actually
needs to be fully enabled in order to correctly clear any pending
overflows. Therefore, invert the sequence to start with turning on both
enables so that we can reliably get the DTCs into a known state, then
moving to our normal counters-stopped state from there. Since all the
DTM counters have already been unpaired during the initial discovery
pass, we just need to additionally reset the cycle counters to ensure
that no other unexpected overflows occur during this period.

Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver")
Reported-by: Geoff Blake <blakgeof@amazon.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/0ea4559261ea394f827c9aee5168c77a60aaee03.1684946389.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/arm-cmn.c