net_sched: avoid resetting active qdisc for multiple times
authorCong Wang <xiyou.wangcong@gmail.com>
Wed, 27 May 2020 04:35:26 +0000 (21:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 May 2020 22:05:49 +0000 (15:05 -0700)
commit70f50965338a12e17454c31ad5ece27069719358
tree6fbefb496398d793022646a147b760964106addb
parentf5a7833e83628f18c1ee94e6ffcb1d232f029be9
net_sched: avoid resetting active qdisc for multiple times

Except for sch_mq and sch_mqprio, each dev queue points to the
same root qdisc, so when we reset the dev queues with
netdev_for_each_tx_queue() we end up resetting the same instance
of the root qdisc for multiple times.

Avoid this by checking the __QDISC_STATE_DEACTIVATED bit in
each iteration, so for sch_mq/sch_mqprio, we still reset all
of them like before, for the rest, we only reset it once.

Reported-by: Václav Zindulka <vaclav.zindulka@tlapnet.cz>
Tested-by: Václav Zindulka <vaclav.zindulka@tlapnet.cz>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c