net: Properly typecast int values to set sk_max_pacing_rate
authorKe Li <keli@akamai.com>
Thu, 22 Oct 2020 06:41:46 +0000 (02:41 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Oct 2020 19:18:25 +0000 (12:18 -0700)
commit700465fd338fe5df08a1b2e27fa16981f562547f
tree23e90f011ffc4683537eaac1b2322fe4ee4390db
parent594850ca439d036173ace66e7f0d022f132f70a8
net: Properly typecast int values to set sk_max_pacing_rate

In setsockopt(SO_MAX_PACING_RATE) on 64bit systems, sk_max_pacing_rate,
after extended from 'u32' to 'unsigned long', takes unintentionally
hiked value whenever assigned from an 'int' value with MSB=1, due to
binary sign extension in promoting s32 to u64, e.g. 0x80000000 becomes
0xFFFFFFFF80000000.

Thus inflated sk_max_pacing_rate causes subsequent getsockopt to return
~0U unexpectedly. It may also result in increased pacing rate.

Fix by explicitly casting the 'int' value to 'unsigned int' before
assigning it to sk_max_pacing_rate, for zero extension to happen.

Fixes: 76a9ebe811fb ("net: extend sk_pacing_rate to unsigned long")
Signed-off-by: Ji Li <jli@akamai.com>
Signed-off-by: Ke Li <keli@akamai.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20201022064146.79873-1-keli@akamai.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/filter.c
net/core/sock.c