random: vDSO: move prototype of arch chacha function to vdso/getrandom.h
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 27 Aug 2024 15:14:18 +0000 (17:14 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Fri, 13 Sep 2024 15:28:35 +0000 (17:28 +0200)
commit6fd13b282f62bd840f2410692deaa23a42fd91fa
tree14674818fd45938409c5b6f95158f0b8c2415abd
parent2aec90036dcd2cb7047a6e28625fba6c64756665
random: vDSO: move prototype of arch chacha function to vdso/getrandom.h

Having the prototype for __arch_chacha20_blocks_nostack in
arch/x86/include/asm/vdso/getrandom.h meant that the prototype and large
doc comment were cloned by every architecture, which has been causing
unnecessary churn. Instead move it into include/vdso/getrandom.h, where
it can be shared by all archs implementing it.

As a side bonus, this then lets us use that prototype in the
vdso_test_chacha self test, to ensure that it matches the source, and
indeed doing so turned up some inconsistencies, which are rectified
here.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
arch/x86/include/asm/vdso/getrandom.h
include/vdso/getrandom.h
tools/testing/selftests/vDSO/vdso_test_chacha.c