afs: Increase buffer size in afs_update_volume_status()
authorDaniil Dulov <d.dulov@aladdin.ru>
Mon, 19 Feb 2024 14:39:03 +0000 (14:39 +0000)
committerChristian Brauner <brauner@kernel.org>
Tue, 20 Feb 2024 08:51:21 +0000 (09:51 +0100)
commit6ea38e2aeb72349cad50e38899b0ba6fbcb2af3d
tree8509e705b8e993b3ae8711ee7bf56e7802332019
parentbfacaf71a1482d936804213a3ffa6de73558280e
afs: Increase buffer size in afs_update_volume_status()

The max length of volume->vid value is 20 characters.
So increase idbuf[] size up to 24 to avoid overflow.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

[DH: Actually, it's 20 + NUL, so increase it to 24 and use snprintf()]

Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20240211150442.3416-1-d.dulov@aladdin.ru/
Link: https://lore.kernel.org/r/20240212083347.10742-1-d.dulov@aladdin.ru/
Link: https://lore.kernel.org/r/20240219143906.138346-3-dhowells@redhat.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/afs/volume.c