tun: Fix use-after-free on XDP_TX
authorToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Fri, 13 Jul 2018 04:24:38 +0000 (13:24 +0900)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Jul 2018 20:38:29 +0000 (13:38 -0700)
commit6e8cfd6d9d8049e2fd5b2de8a328519dc58ea1e6
tree29bab783321200f51b5e37d0f6c22bb78c873890
parent9f80a0723bf0401da63b75709a0e3f31cd4b9446
tun: Fix use-after-free on XDP_TX

On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a
negative value. A positive value indicates that the packet is
successfully enqueued to the ptr_ring, so freeing the page causes
use-after-free.

Fixes: 735fc4054b3a ("xdp: change ndo_xdp_xmit API to support bulking")
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c