kunit: Do not typecheck binary assertions
authorDavid Gow <davidgow@google.com>
Thu, 13 May 2021 19:31:55 +0000 (12:31 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 23 Jun 2021 22:34:27 +0000 (16:34 -0600)
commit6e62dfa6d14f8fd2b07ad30b8a1c597d40d36ac1
tree61867cb523a745cf416cd68a87e2ceeff1304b14
parent2ec73ece4efd818536519f1c5908017122d2e7b5
kunit: Do not typecheck binary assertions

The use of typecheck() in KUNIT_EXPECT_EQ() and friends is causing more
problems than I think it's worth. Things like enums need to have their
values explicitly cast, and literals all need to be very precisely
typed, else a large warning will be printed.

While typechecking does have its uses, the additional overhead of having
lots of needless casts -- combined with the awkward error messages which
don't mention which types are involved -- makes tests less readable and
more difficult to write.

By removing the typecheck() call, the two arguments still need to be of
compatible types, but don't need to be of exactly the same time, which
seems a less confusing and more useful compromise.

Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h