leds: max77705: Function return instead of variable assignment
authorLen Bao <len.bao@gmx.us>
Sun, 27 Jul 2025 07:56:45 +0000 (07:56 +0000)
committerLee Jones <lee@kernel.org>
Mon, 18 Aug 2025 08:49:04 +0000 (09:49 +0100)
commit6e3779e3c6f9dcc9267bf98bef70773a0b13dcbb
tree4bc2fba1b09f042bedbcd17de9f725bd71f22163
parentf4fc2d87aa167e3da5333c3db6cf702db1f98c05
leds: max77705: Function return instead of variable assignment

Coverity noticed that assigning value -EINVAL to 'ret' in the if
statement is useless because 'ret' is overwritten a few lines later.
However, after inspect the code, this warning reveals that we need to
return -EINVAL instead of the variable assignment. So, fix it.

Coverity-id: 1646104
Fixes: aebb5fc9a0d8 ("leds: max77705: Add LEDs support")
Signed-off-by: Len Bao <len.bao@gmx.us>
Link: https://lore.kernel.org/r/20250727075649.34496-1-len.bao@gmx.us
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-max77705.c