ipv6: ioam: fix heap buffer overflow in __ioam6_fill_trace_data()
authorQanux <qjx1298677004@gmail.com>
Wed, 11 Feb 2026 04:04:12 +0000 (12:04 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Feb 2026 20:24:05 +0000 (12:24 -0800)
commit6db8b56eed62baacaf37486e83378a72635c04cc
treebda8e39e573e438273d24baa4b2d4d427e28b284
parenta68a9bd086c2822d0c629443bd16ad1317afe501
ipv6: ioam: fix heap buffer overflow in __ioam6_fill_trace_data()

On the receive path, __ioam6_fill_trace_data() uses trace->nodelen
to decide how much data to write for each node. It trusts this field
as-is from the incoming packet, with no consistency check against
trace->type (the 24-bit field that tells which data items are
present). A crafted packet can set nodelen=0 while setting type bits
0-21, causing the function to write ~100 bytes past the allocated
region (into skb_shared_info), which corrupts adjacent heap memory
and leads to a kernel panic.

Add a shared helper ioam6_trace_compute_nodelen() in ioam6.c to
derive the expected nodelen from the type field, and use it:

  - in ioam6_iptunnel.c (send path, existing validation) to replace
    the open-coded computation;
  - in exthdrs.c (receive path, ipv6_hop_ioam) to drop packets whose
    nodelen is inconsistent with the type field, before any data is
    written.

Per RFC 9197, bits 12-21 are each short (4-octet) fields, so they
are included in IOAM6_MASK_SHORT_FIELDS (changed from 0xff100000 to
0xff1ffc00).

Fixes: 9ee11f0fff20 ("ipv6: ioam: Data plane support for Pre-allocated Trace")
Cc: stable@vger.kernel.org
Signed-off-by: Junxi Qian <qjx1298677004@gmail.com>
Reviewed-by: Justin Iurman <justin.iurman@gmail.com>
Link: https://patch.msgid.link/20260211040412.86195-1-qjx1298677004@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/ioam6.h
net/ipv6/exthdrs.c
net/ipv6/ioam6.c
net/ipv6/ioam6_iptunnel.c