powerpc/ps3: make system bus's remove and shutdown callbacks return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 26 Nov 2020 16:59:50 +0000 (17:59 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 3 Dec 2020 14:01:22 +0000 (01:01 +1100)
commit6d247e4d264961aa3b871290f9b11a48d5a567f2
treeb3fa945f32e251908f2177e26cca191bb817535b
parent7ff94669e7d8e50756cd57947283381ae9665759
powerpc/ps3: make system bus's remove and shutdown callbacks return void

The driver core ignores the return value of struct device_driver::remove
because there is only little that can be done. For the shutdown callback
it's ps3_system_bus_shutdown() which ignores the return value.

To simplify the quest to make struct device_driver::remove return void,
let struct ps3_system_bus_driver::remove return void, too. All users
already unconditionally return 0, this commit makes it obvious that
returning an error code is a bad idea and ensures future users behave
accordingly.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201126165950.2554997-2-u.kleine-koenig@pengutronix.de
13 files changed:
arch/powerpc/include/asm/ps3.h
arch/powerpc/platforms/ps3/system-bus.c
drivers/block/ps3disk.c
drivers/block/ps3vram.c
drivers/char/ps3flash.c
drivers/net/ethernet/toshiba/ps3_gelic_net.c
drivers/ps3/ps3-lpm.c
drivers/ps3/ps3-vuart.c
drivers/scsi/ps3rom.c
drivers/usb/host/ehci-ps3.c
drivers/usb/host/ohci-ps3.c
drivers/video/fbdev/ps3fb.c
sound/ppc/snd_ps3.c