nvmem: u-boot-env: improve coding style
authorRafał Miłecki <rafal@milecki.pl>
Thu, 21 Dec 2023 17:34:20 +0000 (18:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jan 2024 16:01:13 +0000 (17:01 +0100)
commit6bafe07c930676d6430be471310958070816a595
tree8610703a5814a500e04170f7451fd2fbb30b2889
parenta832556d23c5a11115f300011a5874d6107a0d62
nvmem: u-boot-env: improve coding style

1. Prefer kzalloc() over kcalloc()
   See memory-allocation.rst which says: "to be on the safe side it's
   best to use routines that set memory to zero, like kzalloc()"
2. Drop dev_err() for u_boot_env_add_cells() fail
   It can fail only on -ENOMEM. We don't want to print error then.
3. Add extra "crc32_addr" variable
   It makes code reading header's crc32 easier to understand / review.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20231221173421.13737-5-zajec5@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/u-boot-env.c