ext4: remove ext4_xattr_check_entry()
authorEric Biggers <ebiggers@google.com>
Sun, 30 Apr 2017 04:01:02 +0000 (00:01 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 30 Apr 2017 04:01:02 +0000 (00:01 -0400)
commit6ba644b9fd8ce243687139dbd8ca918ad4b09f61
tree0583ffa3ed9aec5fb08d8601ca3e8f39bcda6cd8
parent2c4f9923374843384cfd3a2edc0f02c19a7a29e2
ext4: remove ext4_xattr_check_entry()

ext4_xattr_check_entry() was redundant with validation of the full xattr
entries list in ext4_xattr_check_entries(), which all callers also did.
ext4_xattr_check_entry() also didn't actually do correct validation;
specifically, it never checked that the value doesn't overlap the xattr
names, nor did it account for padding when checking whether the xattr
value overflows the available space.  So remove it to eliminate any
potential confusion.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/xattr.c