net: ipv4: fix infinite loop on secondary addr promotion
authorFlorian Westphal <fw@strlen.de>
Thu, 27 Jun 2019 12:03:32 +0000 (14:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Jun 2019 16:54:34 +0000 (09:54 -0700)
commit6a9e9cea4c51dd7137f381710bb42e2ad6e7e285
tree57b256e5356e97686e4c57fad2236b0f947c187e
parent5b9469a285ebc85af29736a6d9fa995aea0dbf0b
net: ipv4: fix infinite loop on secondary addr promotion

secondary address promotion causes infinite loop -- it arranges
for ifa->ifa_next to point back to itself.

Problem is that 'prev_prom' and 'last_prim' might point at the same entry,
so 'last_sec' pointer must be obtained after prev_prom->next update.

Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
Reported-by: Ran Rozenstein <ranro@mellanox.com>
Reported-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/devinet.c