hwrng: core - Remove add_early_randomness
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 22 May 2024 05:37:54 +0000 (13:37 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 26 May 2024 10:32:16 +0000 (18:32 +0800)
commit67ec8cdf29971677b2fb4b6d92871eb5d5e95597
treef190322f9ff9fef9abb69ca97d0cd46dfb0eab93
parentc6ab5c915da460c0397960af3c308386c3f3247b
hwrng: core - Remove add_early_randomness

A potential deadlock was reported with the config file at

https://web.archive.org/web/20240522052129/https://0x0.st/XPN_.txt

In this particular configuration, the deadlock doesn't exist because
the warning triggered at a point before modules were even available.
However, the deadlock can be real because any module loaded would
invoke async_synchronize_full.

The issue is spurious for software crypto algorithms which aren't
themselves involved in async probing.  However, it would be hard to
avoid for a PCI crypto driver using async probing.

In this particular call trace, the problem is easily avoided because
the only reason the module is being requested during probing is the
add_early_randomness call in the hwrng core.  This feature is
vestigial since there is now a kernel thread dedicated to doing
exactly this.

So remove add_early_randomness as it is no longer needed.

Reported-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 1b6d7f9eb150 ("tpm: add session encryption protection to tpm2_get_random()")
Link: https://lore.kernel.org/r/119dc5ed-f159-41be-9dda-1a056f29888d@notapiano/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Tested-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/core.c