net: ipa: always inline ipa_aggr_granularity_val()
authorAlex Elder <elder@linaro.org>
Wed, 11 Aug 2021 13:59:48 +0000 (08:59 -0500)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Aug 2021 21:51:44 +0000 (14:51 -0700)
commit676eec8efd8ed7f051ea84bfa9c1332e656b5c7d
treef55688b105f67acca49020add672c1131aacf35b
parentbed5a942e27e1df67250e27e1f2eb5ea2d4cc362
net: ipa: always inline ipa_aggr_granularity_val()

It isn't required, but all callers of ipa_aggr_granularity_val()
pass a constant value (IPA_AGGR_GRANULARITY) as the usec argument.
Two of those callers are in ipa_validate_build(), with the result
being passed to BUILD_BUG_ON().

Evidently the "sparc64-linux-gcc" compiler (at least) doesn't always
inline ipa_aggr_granularity_val(), so the result of the function is
not constant at compile time, and that leads to build errors.

Define the function with the __always_inline attribute to avoid the
errors.  We can see by inspection that the value passed is never
zero, so we can just remove its WARN_ON() call.

Fixes: 5bc5588466a1f ("net: ipa: use WARN_ON() rather than assertions")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20210811135948.2634264-1-elder@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_main.c