net: fix use-after-free in GRO with ESP
authorSabrina Dubroca <sd@queasysnail.net>
Sat, 30 Jun 2018 15:38:55 +0000 (17:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Jul 2018 11:34:04 +0000 (20:34 +0900)
commit603d4cf8fe095b1ee78f423d514427be507fb513
treea4051b67f31ba061752f8c5326fa9c6aab528e7f
parent1236f22fbae15df3736ab4a984c64c0c6ee6254c
net: fix use-after-free in GRO with ESP

Since the addition of GRO for ESP, gro_receive can consume the skb and
return -EINPROGRESS. In that case, the lower layer GRO handler cannot
touch the skb anymore.

Commit 5f114163f2f5 ("net: Add a skb_gro_flush_final helper.") converted
some of the gro_receive handlers that can lead to ESP's gro_receive so
that they wouldn't access the skb when -EINPROGRESS is returned, but
missed other spots, mainly in tunneling protocols.

This patch finishes the conversion to using skb_gro_flush_final(), and
adds a new helper, skb_gro_flush_final_remcsum(), used in VXLAN and
GUE.

Fixes: 5f114163f2f5 ("net: Add a skb_gro_flush_final helper.")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/geneve.c
drivers/net/vxlan.c
include/linux/netdevice.h
net/8021q/vlan.c
net/ipv4/fou.c
net/ipv4/gre_offload.c
net/ipv4/udp_offload.c