bpf: Fix use-after-free in bpf_uprobe_multi_link_attach()
authorOleg Nesterov <oleg@redhat.com>
Tue, 13 Aug 2024 15:25:24 +0000 (17:25 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 5 Sep 2024 14:56:13 +0000 (16:56 +0200)
commit5fe6e308abaea082c20fbf2aa5df8e14495622cf
treec8d9ce8763aa55e7537acffb467f8d653b18c656
parent62c0b1061593d7012292f781f11145b2d46f43ab
bpf: Fix use-after-free in bpf_uprobe_multi_link_attach()

If bpf_link_prime() fails, bpf_uprobe_multi_link_attach() goes to the
error_free label and frees the array of bpf_uprobe's without calling
bpf_uprobe_unregister().

This leaks bpf_uprobe->uprobe and worse, this frees bpf_uprobe->consumer
without removing it from the uprobe->consumers list.

Fixes: 89ae89f53d20 ("bpf: Add multi uprobe link")
Closes: https://lore.kernel.org/all/000000000000382d39061f59f2dd@google.com/
Reported-by: syzbot+f7a1c2c2711e4a780f19@syzkaller.appspotmail.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: syzbot+f7a1c2c2711e4a780f19@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240813152524.GA7292@redhat.com
kernel/trace/bpf_trace.c