mptcp: prefer strscpy over strcpy
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 14 May 2024 01:13:29 +0000 (18:13 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 May 2024 01:29:23 +0000 (18:29 -0700)
commit5eae7a8202f368a77ff0148729a9fa73cc24033a
treef33cc109811e609407169dc5deb3cd0054fb1d20
parent73c900aa3660dae2050af456d1031d098ab4cb1d
mptcp: prefer strscpy over strcpy

strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. The safe replacement is strscpy() [1].

This is in preparation of a possible future step where all strcpy() uses
will be removed in favour of strscpy() [2].

This fixes CheckPatch warnings:

  WARNING: Prefer strscpy over strcpy

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Link: https://github.com/KSPP/linux/issues/88
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20240514011335.176158-6-martineau@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/ctrl.c
net/mptcp/protocol.c
net/mptcp/sockopt.c