net: dsa: remove deprecated strncpy
authorjustinstitt@google.com <justinstitt@google.com>
Tue, 18 Jul 2023 22:56:38 +0000 (22:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 23 Jul 2023 10:45:46 +0000 (11:45 +0100)
commit5c9f7b04aadf79f783542d096dfbb8184e7c91f5
treef647a4d21ae76b1f97c73d53086b72bd57694ed8
parent2e60314c2809408f999c080cf3980dc5a5b5ce96
net: dsa: remove deprecated strncpy

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

Even call sites utilizing length-bounded destination buffers should
switch over to using `strtomem` or `strtomem_pad`. In this case,
however, the compiler is unable to determine the size of the `data`
buffer which renders `strtomem` unusable. Due to this, `strscpy`
should be used.

It should be noted that most call sites already zero-initialize the
destination buffer. However, I've opted to use `strscpy_pad` to maintain
the same exact behavior that `strncpy` produced (zero-padded tail up to
`len`).

Also see [3].

[1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
[2]: elixir.bootlin.com/linux/v6.3/source/net/ethtool/ioctl.c#L1944
[3]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html

Link: https://github.com/KSPP/linux/issues/90
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c