Input: powermate - fix use-after-free in powermate_config_complete
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Sat, 14 Oct 2023 03:11:33 +0000 (20:11 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 14 Oct 2023 03:17:02 +0000 (20:17 -0700)
commit5c15c60e7be615f05a45cd905093a54b11f461bc
tree5d69dab1991141d5ea7409dc545f2c7c5d61a47d
parenta65cd7ef5a864bdbbe037267c327786b7759d4c6
Input: powermate - fix use-after-free in powermate_config_complete

syzbot has found a use-after-free bug [1] in the powermate driver. This
happens when the device is disconnected, which leads to a memory free from
the powermate_device struct.  When an asynchronous control message
completes after the kfree and its callback is invoked, the lock does not
exist anymore and hence the bug.

Use usb_kill_urb() on pm->config to cancel any in-progress requests upon
device disconnection.

[1] https://syzkaller.appspot.com/bug?extid=0434ac83f907a1dbdd1e

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reported-by: syzbot+0434ac83f907a1dbdd1e@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20230916-topic-powermate_use_after_free-v3-1-64412b81a7a2@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/powermate.c