blk-iocost: ioc_pd_free() shouldn't assume irq disabled
authorTejun Heo <tj@kernel.org>
Tue, 1 Sep 2020 18:52:31 +0000 (14:52 -0400)
committerJens Axboe <axboe@kernel.dk>
Tue, 1 Sep 2020 22:48:44 +0000 (16:48 -0600)
commit5aeac7c4b16069aae49005f0a8d4526baa83341b
treed380ddce8bf1e1a8d2e043e1491ba3da588ef89f
parent08fc1ab6d748ab1a690fd483f41e2938984ce353
blk-iocost: ioc_pd_free() shouldn't assume irq disabled

ioc_pd_free() grabs irq-safe ioc->lock without ensuring that irq is disabled
when it can be called with irq disabled or enabled. This has a small chance
of causing A-A deadlocks and triggers lockdep splats. Use irqsave operations
instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 7caa47151ab2 ("blkcg: implement blk-iocost")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c