drm/amd/display: Fix kernel panic by dal_gpio_open() error
authorTakashi Iwai <tiwai@suse.de>
Fri, 23 Oct 2020 07:46:54 +0000 (09:46 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 26 Oct 2020 20:52:00 +0000 (16:52 -0400)
commit594b6f7370a84ae7fd87e16e2e8560874a01d70c
tree016457be10c77a2e8da72ee6481d9224cd9c0e02
parent44ea03e17ef5ca4a5f527ffbb26c57d16758bac9
drm/amd/display: Fix kernel panic by dal_gpio_open() error

Currently both error code paths handled in dal_gpio_open_ex() issues
ASSERT_CRITICAL(), and this leads to a kernel panic unnecessarily if
CONFIG_KGDB is enabled.  Since basically both are non-critical errors
and can be recovered, drop those assert calls and use a safer one,
BREAK_TO_DEBUGGER(), for allowing the debugging, instead.

BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1177973
Cc: <stable@vger.kernel.org>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c