statx: correct error handling of NULL pathname
authorMichael Kerrisk (man-pages) <mtk.manpages@gmail.com>
Thu, 27 Apr 2017 11:54:11 +0000 (13:54 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 Apr 2017 17:45:09 +0000 (10:45 -0700)
commit59372bbf3abd5b24a7f6f676a3968685c280f955
tree1b9fde933d8e9cbd7dec3c39521ca0cb16eed73d
parentf83246089ca09308425175d47f5e71e6da68b2ef
statx: correct error handling of NULL pathname

The change in commit 1e2f82d1e9d1 ("statx: Kill fd-with-NULL-path
support in favour of AT_EMPTY_PATH") to error on a NULL pathname to
statx() is inconsistent.

It results in the error EINVAL for a NULL pathname.  Other system calls
with similar APIs (fchownat(), fstatat(), linkat()), return EFAULT.

The solution is simply to remove the EINVAL check.  As I already pointed
out in [1], user_path_at*() and filename_lookup() will handle the NULL
pathname as per the other APIs, to correctly produce the error EFAULT.

[1] https://lkml.org/lkml/2017/4/26/561

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/stat.c