ext4: fix potential negative array index in do_split()
authorEric Sandeen <sandeen@redhat.com>
Wed, 17 Jun 2020 19:19:04 +0000 (14:19 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 6 Aug 2020 04:11:16 +0000 (00:11 -0400)
commit5872331b3d91820e14716632ebb56b1399b34fe1
tree4f35152ee730e3ad04766cedebad6b0a336a3bd1
parent24dc9864914eb5813173cfa53313fcd02e4aea7d
ext4: fix potential negative array index in do_split()

If for any reason a directory passed to do_split() does not have enough
active entries to exceed half the size of the block, we can end up
iterating over all "count" entries without finding a split point.

In this case, count == move, and split will be zero, and we will
attempt a negative index into map[].

Guard against this by detecting this case, and falling back to
split-to-half-of-count instead; in this case we will still have
plenty of space (> half blocksize) in each split block.

Fixes: ef2b02d3e617 ("ext34: ensure do_split leaves enough free space in both blocks")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/f53e246b-647c-64bb-16ec-135383c70ad7@redhat.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/namei.c