xfs: __percpu_counter_compare() inode count debug too expensive
authorDave Chinner <dchinner@redhat.com>
Mon, 22 Mar 2021 16:52:06 +0000 (09:52 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 25 Mar 2021 23:47:52 +0000 (16:47 -0700)
commit5825bea05265d2938c4c20a1c0f8b7d7ab59523d
treeee3a83f9e06dee22c1a659317b2904c2b94584c7
parent1fea323ff00526dcc04fbb4ee6e7d04e4e2ab0e1
xfs: __percpu_counter_compare() inode count debug too expensive

- 21.92% __xfs_trans_commit
     - 21.62% xfs_log_commit_cil
- 11.69% xfs_trans_unreserve_and_mod_sb
   - 11.58% __percpu_counter_compare
      - 11.45% __percpu_counter_sum
 - 10.29% _raw_spin_lock_irqsave
    - 10.28% do_raw_spin_lock
 __pv_queued_spin_lock_slowpath

We debated just getting rid of it last time this came up and
there was no real objection to removing it. Now it's the biggest
scalability limitation for debug kernels even on smallish machines,
so let's just get rid of it.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_trans.c