iavf: fix double unlock of crit_lock
authorStefan Assmann <sassmann@kpanic.de>
Tue, 24 Aug 2021 10:06:39 +0000 (12:06 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 6 Oct 2021 16:49:34 +0000 (09:49 -0700)
commit54ee39439acd9f8b161703c6ad4f4e1835585277
tree93db707f465fba18bf00fb527ab47bdeb5371be3
parent2e5a20573a926302b233b0c2e1077f5debc7ab2e
iavf: fix double unlock of crit_lock

The crit_lock mutex could be unlocked twice as reported here
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20210823/025525.html

Remove the superfluous unlock. Technically the problem was already
present before 5ac49f3c2702 as that commit only replaced the locking
primitive, but no functional change.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 5ac49f3c2702 ("iavf: use mutexes for locking of critical sections")
Fixes: bac8486116b0 ("iavf: Refactor the watchdog state machine")
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c