usb: roles: Fix potential NULL dereference in intel_xhci_usb_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 29 Mar 2018 02:14:11 +0000 (02:14 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Apr 2018 13:49:42 +0000 (15:49 +0200)
commit548f4726a10568c208a7a9d676d66470e9e99aa3
tree15965bebb61140749256dd74b919f525d5487c43
parent03eb4c33140da16e02c4f47e53c0421681bde8ce
usb: roles: Fix potential NULL dereference in intel_xhci_usb_probe()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/roles/intel-xhci-usb-role-switch.c