spi: spi-mem: add spi_mem_dtr_supports_op()
authorPratyush Yadav <p.yadav@ti.com>
Thu, 4 Feb 2021 14:12:17 +0000 (19:42 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 11 Feb 2021 15:51:36 +0000 (15:51 +0000)
commit539cf68cd51bfcd2987ce1c44e628e9da69de7c8
tree2b6565ddd1af91a6e7b81f69bfcaee6ff91cbad5
parentdf6978b7ea6349eb32078c42b917559f5510aebd
spi: spi-mem: add spi_mem_dtr_supports_op()

spi_mem_default_supports_op() rejects DTR ops by default to ensure that
the controller drivers that haven't been updated with DTR support
continue to reject them. It also makes sure that controllers that don't
support DTR mode at all (which is most of them at the moment) also
reject them.

This means that controller drivers that want to support DTR mode can't
use spi_mem_default_supports_op(). Driver authors have to roll their own
supports_op() function and mimic the buswidth checks. See
spi-cadence-quadspi.c for example. Or even worse, driver authors might
skip it completely or get it wrong.

Add spi_mem_dtr_supports_op(). It provides a basic sanity check for DTR
ops and performs the buswidth requirement check. Move the logic for
checking buswidth in spi_mem_default_supports_op() to a separate
function so the logic is not repeated twice.

Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20210204141218.32229-1-p.yadav@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mem.c
include/linux/spi/spi-mem.h