drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 2 Nov 2020 16:19:31 +0000 (16:19 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 4 Nov 2020 00:22:42 +0000 (19:22 -0500)
commit537457a979a02a410b555fab289dcb28b588f33b
tree03fd6a3258c548326e0733f1e9efae9ffd3e3792
parente67d01d8494640018b08cd767aeb2824a8e11983
drm/i915: Hold onto an explicit ref to i915_vma_work.pinned

Since __vma_release is run by a kworker after the fence has been
signaled, it is no longer protected by the active reference on the vma,
and so the alias of vw->pinned to vma->obj is also not protected by a
reference on the object. Add an explicit reference for vw->pinned so it
will always be safe.

Found by inspection.

Fixes: 54d7195f8c64 ("drm/i915: Unpin vma->obj on early error")
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201102161931.30031-1-chris@chris-wilson.co.uk
(cherry picked from commit bc73e5d33048b7ab5f12b11b5d923700467a8e1d)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/i915_vma.c