liquidio: replace deprecated strncpy/strcpy with strscpy
authorJustin Stitt <justinstitt@google.com>
Thu, 5 Oct 2023 21:33:19 +0000 (21:33 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Oct 2023 02:38:41 +0000 (19:38 -0700)
commit52cdbea1a54aba106e6c616c0500a12a965ecbbe
treea66833953e483cff67d273f3744c7662b8445bd9
parent0aba524728f0d893829f6909c40608390a1912c1
liquidio: replace deprecated strncpy/strcpy with strscpy

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

NUL-padding is not required as drvinfo is memset to 0:
| memset(drvinfo, 0, sizeof(struct ethtool_drvinfo));

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20231005-strncpy-drivers-net-ethernet-cavium-liquidio-lio_ethtool-c-v1-1-ab565ab4d197@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cavium/liquidio/lio_ethtool.c