perf symbols: only set vmlinux longname & mark loaded if really loaded
authorCody P Schafer <cody@linux.vnet.ibm.com>
Fri, 10 Aug 2012 22:22:54 +0000 (15:22 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 13 Aug 2012 17:24:12 +0000 (14:24 -0300)
commit515850e4fbd87c8f249446faa2e5ad98e672711d
tree00dc3c8d8ab61b1d44018534ed9e20044b0bf079
parent0a0317b41e20770f81bc61d7b208957385466c3f
perf symbols: only set vmlinux longname & mark loaded if really loaded

dso__load_vmlinux() uses the filename passed to it to directly set the
dso long_name, which resulted in a use after free due to
dso__load_vmlinux_path() treating 0 symbols as a load failure and
subsequently freeing the contents of dso->long_name.

Change dso__load_vmlinux() so that finding 0 symbols does not cause it
to consider itself loaded, and do not set long_name in such a case.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-9-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/symbol.c