tpm_tis: Explicitly check for error code
authorAlexander Steffen <Alexander.Steffen@infineon.com>
Tue, 13 Jun 2023 18:02:56 +0000 (20:02 +0200)
committerJarkko Sakkinen <jarkko@kernel.org>
Fri, 28 Jul 2023 18:13:39 +0000 (18:13 +0000)
commit513253f8c293c0c8bd46d09d337fc892bf8f9f48
tree7810977bfd519231ffa25bd957dab9bb8bc5fe96
parentbe6f48a7c8e44a15ffc95f6f323dec548a4b990e
tpm_tis: Explicitly check for error code

recv_data either returns the number of received bytes, or a negative value
representing an error code. Adding the return value directly to the total
number of received bytes therefore looks a little weird, since it might add
a negative error code to a sum of bytes.

The following check for size < expected usually makes the function return
ETIME in that case, so it does not cause too many problems in practice. But
to make the code look cleaner and because the caller might still be
interested in the original error code, explicitly check for the presence of
an error code and pass that through.

Cc: stable@vger.kernel.org
Fixes: cb5354253af2 ("[PATCH] tpm: spacing cleanups 2")
Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_core.c