netfilter: xt_TCPMSS: Refactor the codes to decrease one condition check and more...
authorGao Feng <fgao@ikuai8.com>
Wed, 7 Sep 2016 02:40:24 +0000 (10:40 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sat, 24 Sep 2016 19:13:21 +0000 (21:13 +0200)
commit50f4c7b73f831a53fa9ddeb9bdf4cfb5b23d3aa7
treeec56a874a264b53e2313340d2c42c9e6cb27ea86
parent4004d5c374dabcbce201e16442e4596b764cc60b
netfilter: xt_TCPMSS: Refactor the codes to decrease one condition check and more readable

The origin codes perform two condition checks with dst_mtu(skb_dst(skb))
and in_mtu. And the last statement is "min(dst_mtu(skb_dst(skb)),
in_mtu) - minlen". It may let reader think about how about the result.
Would it be negative.

Now assign the result of min(dst_mtu(skb_dst(skb)), in_mtu) to a new
variable, then only perform one condition check, and it is more readable.

Signed-off-by: Gao Feng <fgao@ikuai8.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_TCPMSS.c