ethtool: Fix set RXNFC command with symmetric RSS hash
authorGal Pressman <gal@nvidia.com>
Sun, 26 Jan 2025 19:18:45 +0000 (21:18 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 28 Jan 2025 11:25:42 +0000 (12:25 +0100)
commit4f5a52adeb1ad675ca33f1e1eacd9c0bbaf393d4
tree0c99a8c75eb122dcb7908d1f55148cabaf8ad61c
parente091043bfabef7cb6d970ffd3cbb174847fd6300
ethtool: Fix set RXNFC command with symmetric RSS hash

The sanity check that both source and destination are set when symmetric
RSS hash is requested is only relevant for ETHTOOL_SRXFH (rx-flow-hash),
it should not be performed on any other commands (e.g.
ETHTOOL_SRXCLSRLINS/ETHTOOL_SRXCLSRLDEL).

This resolves accessing uninitialized 'info.data' field, and fixes false
errors in rule insertion:
  # ethtool --config-ntuple eth2 flow-type ip4 dst-ip 255.255.255.255 action -1 loc 0
  rmgr: Cannot insert RX class rule: Invalid argument
  Cannot insert classification rule

Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
Cc: Ahmed Zaki <ahmed.zaki@intel.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
Link: https://patch.msgid.link/20250126191845.316589-1-gal@nvidia.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ethtool/ioctl.c