fix multiplication overflow in copy_fdtable()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 19 May 2020 21:48:52 +0000 (17:48 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 19 May 2020 22:29:36 +0000 (18:29 -0400)
commit4e89b7210403fa4a8acafe7c602b6212b7af6c3b
tree23fa6410018b40b285702244099f20977db8a5f4
parentb0d3869ce9eeacbb1bbd541909beeef4126426d5
fix multiplication overflow in copy_fdtable()

cpy and set really should be size_t; we won't get an overflow on that,
since sysctl_nr_open can't be set above ~(size_t)0 / sizeof(void *),
so nr that would've managed to overflow size_t on that multiplication
won't get anywhere near copy_fdtable() - we'll fail with EMFILE
before that.

Cc: stable@kernel.org # v2.6.25+
Fixes: 9cfe015aa424 (get rid of NR_OPEN and introduce a sysctl_nr_open)
Reported-by: Thiago Macieira <thiago.macieira@intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/file.c