infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2param_change
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 07:33:06 +0000 (15:33 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 18 Apr 2018 01:57:12 +0000 (19:57 -0600)
commit4e56569cee1505846b3dcb15fbf400f6a7e9f015
tree23b80610b5d5da869ad291301ce1073025582e2c
parentf9af8730143a0fdc572f90b8a388795ee812cd74
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2param_change

i40iw_l2param_change() is never called in atomic context.

i40iw_make_listen_node() is only set as ".l2_param_change"
in struct i40e_client_ops, and this function pointer is not called
in atomic context.

Despite never getting called from atomic context,
i40iw_l2param_change() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/i40iw/i40iw_main.c