net/sched: act_police: more accurate MTU policing
authorDavide Caratti <dcaratti@redhat.com>
Thu, 10 Feb 2022 17:56:08 +0000 (18:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Feb 2022 11:15:04 +0000 (11:15 +0000)
commit4ddc844eb81da59bfb816d8d52089aba4e59e269
treec01f737c2999d8e54eebb7d4a7e473cff075595c
parent2618a0dae09ef37728dab89ff60418cbe25ae6bd
net/sched: act_police: more accurate MTU policing

in current Linux, MTU policing does not take into account that packets at
the TC ingress have the L2 header pulled. Thus, the same TC police action
(with the same value of tcfp_mtu) behaves differently for ingress/egress.
In addition, the full GSO size is compared to tcfp_mtu: as a consequence,
the policer drops GSO packets even when individual segments have the L2 +
L3 + L4 + payload length below the configured valued of tcfp_mtu.

Improve the accuracy of MTU policing as follows:
 - account for mac_len for non-GSO packets at TC ingress.
 - compare MTU threshold with the segmented size for GSO packets.
Also, add a kselftest that verifies the correct behavior.

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_police.c
tools/testing/selftests/net/forwarding/tc_police.sh