regmap: Fix race condition in hwspinlock irqsave routine
authorCheng-Yu Lee <cylee12@realtek.com>
Fri, 9 Jan 2026 03:26:33 +0000 (11:26 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 12 Jan 2026 12:25:29 +0000 (12:25 +0000)
commit4b58aac989c1e3fafb1c68a733811859df388250
treec991b44dfe7e308234af45ac6f887a1f9d16e6eb
parentf3f380ce6b3d5c9805c7e0b3d5bc28d9ec41e2e8
regmap: Fix race condition in hwspinlock irqsave routine

Previously, the address of the shared member '&map->spinlock_flags' was
passed directly to 'hwspin_lock_timeout_irqsave'. This creates a race
condition where multiple contexts contending for the lock could overwrite
the shared flags variable, potentially corrupting the state for the
current lock owner.

Fix this by using a local stack variable 'flags' to store the IRQ state
temporarily.

Fixes: 8698b9364710 ("regmap: Add hardware spinlock support")
Signed-off-by: Cheng-Yu Lee <cylee12@realtek.com>
Co-developed-by: Yu-Chun Lin <eleanor.lin@realtek.com>
Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
Link: https://patch.msgid.link/20260109032633.8732-1-eleanor.lin@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap.c