drm/nouveau/therm: Move an assignment statement behind a null pointer check in two...
authorMarkus Elfring <Markus.Elfring@web.de>
Sun, 16 Apr 2023 08:50:12 +0000 (10:50 +0200)
committerKarol Herbst <kherbst@redhat.com>
Mon, 17 Apr 2023 17:08:04 +0000 (19:08 +0200)
commit4aa35a0130d6b8afbefc9ef530a521fb0fb9b8e1
treef2b78684ded7e408a80a28e4f4a929a5665b047e
parent8a89e1323d7dc90fa551cf2167ab838013641788
drm/nouveau/therm: Move an assignment statement behind a null pointer check in two functions

The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the functions “nvkm_fanpwm_create” and “nvkm_fantog_create”.

Thus avoid the risk for undefined behaviour by moving the assignment
for the data structure member “fan” behind two null pointer checks.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/3d0215dc-74d4-2c42-2eee-7a5fcf62b9f1@web.de
drivers/gpu/drm/nouveau/nvkm/subdev/therm/fanpwm.c
drivers/gpu/drm/nouveau/nvkm/subdev/therm/fantog.c