mei: vsc: Do not re-enable interrupt from vsc_tp_reset()
authorHans de Goede <hdegoede@redhat.com>
Wed, 6 Nov 2024 22:01:02 +0000 (23:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Nov 2024 09:57:48 +0000 (10:57 +0100)
commit49988a7975420eb206c783f8a384458aae85d938
tree2f697dd5884bce0c8ba31c2f13f21399dd4d57bc
parent9aa45ca73ba85035e7953904e2f10353aef7e104
mei: vsc: Do not re-enable interrupt from vsc_tp_reset()

The only 2 callers of vsc_tp_reset() are:

1. mei_vsc_hw_reset(), which immediataly calls vsc_tp_intr_disable()
   afterwards.

2. vsc_tp_shutdown() which immediately calls free_irq() afterwards.

So neither actually wants the interrupt to be enabled after resetting
the chip and having the interrupt enabled for a short time afer
the reset is undesirable.

Drop the enable_irq() call from vsc_tp_reset(), so that the interrupt
is left disabled after vsc_tp_reset().

Link: https://github.com/intel/ivsc-driver/issues/51
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241106220102.40549-1-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/platform-vsc.c
drivers/misc/mei/vsc-tp.c