blk-cgroup: cgroup_rstat_updated() shouldn't be called on cgroup1
authorTejun Heo <tj@kernel.org>
Thu, 14 Nov 2019 22:31:28 +0000 (14:31 -0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 18 Nov 2019 15:40:41 +0000 (08:40 -0700)
commit496074f94b19574c77240d3b3f84cfb1097de51d
tree508ec8a8c34bec8cd9eadfcc2fc1fcb89bffd566
parentde678bc63cc659d056a5ff3a3b11866d3eb4c1a9
blk-cgroup: cgroup_rstat_updated() shouldn't be called on cgroup1

Currently, cgroup rstat is supported only on cgroup2 hierarchy and
rstat functions shouldn't be called on cgroup1 cgroups.  While
converting blk-cgroup core statistics to rstat, f73316482977
("blk-cgroup: reimplement basic IO stats using cgroup rstat")
accidentally ended up calling cgroup_rstat_updated() on cgroup1
cgroups causing crashes.

Longer term, we probably should add cgroup1 support to rstat but for
now let's mask the call directly.

Fixes: f73316482977 ("blk-cgroup: reimplement basic IO stats using cgroup rstat")
Tested-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk-cgroup.h