sctp: use the old asoc when making the cookie-ack chunk in dupcook_d
authorXin Long <lucien.xin@gmail.com>
Wed, 2 May 2018 05:39:46 +0000 (13:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 May 2018 15:15:33 +0000 (11:15 -0400)
commit46e16d4b956867013e0bbd7f2bad206f4aa55752
tree8e48a858378c7ac595d5a75664369b616aa34d0d
parent4842a08fb80bc09b7b089af42c58353dfaa8f88f
sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

When processing a duplicate cookie-echo chunk, for case 'D', sctp will
not process the param from this chunk. It means old asoc has nothing
to be updated, and the new temp asoc doesn't have the complete info.

So there's no reason to use the new asoc when creating the cookie-ack
chunk. Otherwise, like when auth is enabled for cookie-ack, the chunk
can not be set with auth, and it will definitely be dropped by peer.

This issue is there since very beginning, and we fix it by using the
old asoc instead.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_statefuns.c