mmc: core: apply SD quirks earlier during probe
authorJonathan Bell <jonathan@raspberrypi.com>
Tue, 20 Aug 2024 23:06:31 +0000 (08:06 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 26 Aug 2024 11:07:26 +0000 (13:07 +0200)
commit469e5e4713989fdd5e3e502b922e7be0da2464b9
tree3d5942d95a7283f303bca101ac3124e622bddcc6
parent5be63fc19fcaa4c236b307420483578a56986a37
mmc: core: apply SD quirks earlier during probe

Applying MMC_QUIRK_BROKEN_SD_CACHE is broken, as the card's SD quirks are
referenced in sd_parse_ext_reg_perf() prior to the quirks being initialized
in mmc_blk_probe().

To fix this problem, let's split out an SD-specific list of quirks and
apply in mmc_sd_init_card() instead. In this way, sd_read_ext_regs() to has
the available information for not assigning the SD_EXT_PERF_CACHE as one of
the (un)supported features, which in turn allows mmc_sd_init_card() to
properly skip execution of sd_enable_cache().

Fixes: c467c8f08185 ("mmc: Add MMC_QUIRK_BROKEN_SD_CACHE for Kingston Canvas Go Plus from 11/2019")
Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
Co-developed-by: Keita Aihara <keita.aihara@sony.com>
Signed-off-by: Keita Aihara <keita.aihara@sony.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240820230631.GA436523@sony.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/quirks.h
drivers/mmc/core/sd.c