tcp: disallow cwnd undo when switching congestion control
authorYuchung Cheng <ycheng@google.com>
Wed, 31 May 2017 18:21:27 +0000 (11:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Jun 2017 18:18:13 +0000 (14:18 -0400)
commit44abafc4cc094214a99f860f778c48ecb23422fc
tree4829f0b714b71878b9285e9956074992d6aef854
parente7519f9926f1d0d11c776eb0475eb098c7760f68
tcp: disallow cwnd undo when switching congestion control

When the sender switches its congestion control during loss
recovery, if the recovery is spurious then it may incorrectly
revert cwnd and ssthresh to the older values set by a previous
congestion control. Consider a congestion control (like BBR)
that does not use ssthresh and keeps it infinite: the connection
may incorrectly revert cwnd to an infinite value when switching
from BBR to another congestion control.

This patch fixes it by disallowing such cwnd undo operation
upon switching congestion control.  Note that undo_marker
is not reset s.t. the packets that were incorrectly marked
lost would be corrected. We only avoid undoing the cwnd in
tcp_undo_cwnd_reduction().

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_cong.c