Revert "usb: host: ehci: Use dma_pool_zalloc()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 May 2018 21:35:12 +0000 (14:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 May 2018 21:35:12 +0000 (14:35 -0700)
commit43b78f1155c868208a413082179251f5fba78153
treed3e9d5117a2c8523fb82033273ba41c5e65277b5
parent1a2f474d328f292ee706414824ec4ca690cdf5ba
Revert "usb: host: ehci: Use dma_pool_zalloc()"

This reverts commit 22072e83ebd510fb6a090aef9d65ccfda9b1e7e4 as it is
broken.

Alan writes:
What you can't see just from reading the patch is that in both
cases (ehci->itd_pool and ehci->sitd_pool) there are two
allocation paths -- the two branches of an "if" statement -- and
only one of the paths calls dma_pool_[z]alloc.  However, the
memset is needed for both paths, and so it can't be eliminated.
Given that it must be present, there's no advantage to calling
dma_pool_zalloc rather than dma_pool_alloc.

Reported-by: Erick Cafferata <erick@cafferata.me>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Souptick Joarder <jrdr.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-mem.c
drivers/usb/host/ehci-sched.c