arm64: Add missing ISB after invalidating TLB in enter_vhe
authorMarc Zyngier <maz@kernel.org>
Wed, 24 Feb 2021 09:37:38 +0000 (09:37 +0000)
committerWill Deacon <will@kernel.org>
Wed, 24 Feb 2021 11:35:36 +0000 (11:35 +0000)
commit430251cc864beb11ac5b6d2f5c6ef54ddd432612
treeb67d05be63028f9a9a2942d32cea0a17d9dc7322
parent9d41053e8dc115c92b8002c3db5f545d7602498b
arm64: Add missing ISB after invalidating TLB in enter_vhe

Although there has been a bit of back and forth on the subject, it
appears that invalidating TLBs requires an ISB instruction after the
TLBI/DSB sequence when FEAT_ETS is not implemented by the CPU.

From the bible:

  | In an implementation that does not implement FEAT_ETS, a TLB
  | maintenance instruction executed by a PE, PEx, can complete at any
  | time after it is issued, but is only guaranteed to be finished for a
  | PE, PEx, after the execution of DSB by the PEx followed by a Context
  | synchronization event

Add the missing ISB in enter_vhe(), just in case.

Fixes: f359182291c7 ("arm64: Provide an 'upgrade to VHE' stub hypercall")
Suggested-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20210224093738.3629662-4-maz@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/hyp-stub.S